Thread (22 messages) 22 messages, 6 authors, 2024-07-03

Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support

From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2024-07-02 00:19:09
Also in: linux-integrity, lkml, regressions

James Bottomley [off-list ref] writes:
On Fri, 2024-06-28 at 10:54 +1000, Michael Ellerman wrote:
quoted
Stefan Berger [off-list ref] writes:
quoted
Fix the following type of error message caused by a missing call to
tpm2_sessions_init() in the IBM vTPM driver:

[    2.987131] tpm tpm0: tpm2_load_context: failed with a TPM error
0x01C4
[    2.987140] ima: Error Communicating to TPM chip, result: -14

Fixes: d2add27cf2b8 ("tpm: Add NULL primary creation")
Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
---
 drivers/char/tpm/tpm_ibmvtpm.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/drivers/char/tpm/tpm_ibmvtpm.c
b/drivers/char/tpm/tpm_ibmvtpm.c
index d3989b257f42..1e5b107d1f3b 100644
--- a/drivers/char/tpm/tpm_ibmvtpm.c
+++ b/drivers/char/tpm/tpm_ibmvtpm.c
@@ -698,6 +698,10 @@ static int tpm_ibmvtpm_probe(struct vio_dev
*vio_dev,
                rc = tpm2_get_cc_attrs_tbl(chip);
                if (rc)
                        goto init_irq_cleanup;
+
+               rc = tpm2_sessions_init(chip);
+               if (rc)
+                       goto init_irq_cleanup;
        }
 
        return tpm_chip_register(chip);
#regzbot ^introduced: d2add27cf2b8 
Could you please test out the patch I proposed for this:

https://lore.kernel.org/linux-integrity/1302b413a2d7bf3b275133e7fdb04b44bfe2d5e3.camel@HansenPartnership.com/ (local)
Your patch does fix the issue on my PowerVM system, as does Stefan's.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help