Thread (32 messages) 32 messages, 5 authors, 2024-06-18

Re: [PATCH v3 4/4] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs

From: Markus Elfring <hidden>
Date: 2024-06-17 19:37:00
Also in: alsa-devel, linux-arm-kernel, linux-devicetree, linux-sound, lkml

I suggest to specify email addresses for message recipients not only
in the header field “Cc”.


…
quoted hunk ↗ jump to hunk
+++ b/sound/soc/fsl/lpc3xxx-i2s.c
@@ -0,0 +1,393 @@
+static int lpc3xxx_i2s_startup(struct snd_pcm_substream *substream, struct snd_soc_dai *cpu_dai)
+{
+	int ret = 0;
+
+	mutex_lock(&i2s_info_p->lock);
+lpc32xx_unlock:
+	mutex_unlock(&i2s_info_p->lock);
+	return ret;
+}
…

Would you become interested to apply a statement like “guard(mutex)(&i2s_info_p->lock);”?
https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/mutex.h#L196

Regards,
Markus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help