Le 20/05/2024 à 19:42, Oscar Salvador a écrit :

On Mon, May 20, 2024 at 04:31:39PM +0000, Christophe Leroy wrote:

quoted

Hi Oscar, hi Michael,

Le 20/05/2024 à 11:14, Oscar Salvador a écrit :

quoted

On Fri, May 17, 2024 at 09:00:00PM +0200, Christophe Leroy wrote:

quoted

set_huge_pte_at() expects the real page size, not the psize which is

"expects the size of the huge page" sounds bettter?

Parameter 'pzize' already provides the size of the hugepage, but not in
the way set_huge_pte_at() expects it.

psize has one of the values defined by MMU_PAGE_XXX macros defined in
arch/powerpc/include/asm/mmu.h while set_huge_pte_at() expects the size
as a value.

Yes, psize is an index, which is not a size by itself but used to get
mmu_psize_def.shift to see the actual size, I guess.
This is why I thought that being explicit about "expects the size of the
huge page" was better.

But no strong feelings here.

Thanks, I'll try a rephrase.

Christophe