Re: [PATCH 1/1] [RFC] ethernet: Convert from tasklet to BH workqueue

From
Allen <hidden>
Date
2024-05-09 21:38:46
Also in
linux-arm-kernel, linux-mediatek, linux-rdma, lkml, netdev
Reply to
Paolo Abeni, 2024-05-09
Paolo,
On Wed, 2024-05-08 at 21:16 +0100, Simon Horman wrote:
quoted
* As this patch seems to involve many non-trivial changes
  it seems to me that it would be best to break it up somehow.
  To allow proper review.
I would like to stress this latest point: it looks like the changes to
all the drivers are completely independent. If so, you have to break
the series on a per driver basis. Since the total number of patch will
be higher then 15 (maximum size allowed on netdev) you will have to
split this in several smaller series.
 Right, it's a valid point. Per-driver might not work. Depending on the
driver and changes, I will try and make it an independent series.
Beyond making the change reviewable, it will allow eventually reverting
the changes individually, should that cause any regressions.
Thank you, I understand the concern here. Will work on it in v2.

Thank you very much for your time and suggestions.

 - Allen
Thread (8 messages) 8 messages, 5 authors, last reply 2024-05-09
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help