Re: [FSL P50x0] Kernel 6.9-rc1 compiling issue
From: Christophe Leroy <hidden>
Date: 2024-04-04 19:02:15
Hi Christian, hi Hari, Le 04/04/2024 à 19:44, Christian Zigotzky a écrit :
Shall we use CONFIG_CRASH_DUMP to get int crashing_cpu = -1;? Further information: https://lists.ozlabs.org/pipermail/linuxppc-dev/2024-March/269985.html <https://lists.ozlabs.org/pipermail/linuxppc-dev/2024-March/269985.html>
Looking at problematic commit 5c4233cc0920 ("powerpc/kdump: Split
KEXEC_CORE and CRASH_DUMP dependency"), my feeling is that the change
should be as follows.
Hari, can you confirm ?
diff --git a/arch/powerpc/platforms/85xx/smp.c b/arch/powerpc/platforms/85xx/smp.c index 40aa58206888..3209fc92ac19 100644
--- a/arch/powerpc/platforms/85xx/smp.c
+++ b/arch/powerpc/platforms/85xx/smp.c@@ -362,7 +362,7 @@ struct smp_ops_t smp_85xx_ops = { #endif }; -#ifdef CONFIG_KEXEC_CORE +#ifdef CONFIG_CRASH_DUMP #ifdef CONFIG_PPC32 atomic_t kexec_down_cpus = ATOMIC_INIT(0);
@@ -465,7 +465,7 @@ static void mpc85xx_smp_machine_kexec(struct kimage *image)
default_machine_kexec(image);
}
-#endif /* CONFIG_KEXEC_CORE */
+#endif /* CONFIG_CRASH_DUMP */
static void smp_85xx_setup_cpu(int cpu_nr)
{