Thread (4 messages) 4 messages, 3 authors, 2024-04-19

Re: [PATCH] i2c: mpc: Removal of of_node_put with __free for auto cleanup

From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Date: 2024-04-16 03:59:21
Also in: linux-i2c, lkml

On 16/04/24 08:54, Andi Shyti wrote:
Hi Abhinav,
quoted
  	/* Enable I2C interrupts for mpc5121 */
-	node_ctrl = of_find_compatible_node(NULL, NULL,
-					    "fsl,mpc5121-i2c-ctrl");
+	struct device_node *node_ctrl __free(device_node) =
How have you tested this?
I'm not sure I know anyone that still has a mpc5121. Maybe someone on 
linuxppc-dev?

I did try to take the patch for a spin on my T2081RDB but I'm having 
some userland issues on it for some reason (unrelated to this change). 
The kernel boot does discover a few peripherals hanging of the I2C 
interface but I'm not in a position to offer up a Tested-by and I've run 
out of time to debug why my board is unhappy.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help