Re: [PATCH 3/4] mmu_notifier: remove the .change_pte() callback
From: David Hildenbrand <hidden>
Date: 2024-04-08 07:35:28
Also in:
kvm, kvm-riscv, kvmarm, linux-arm-kernel, linux-mips, linux-mm, linux-perf-users, linux-trace-kernel, lkml, loongarch
On 05.04.24 13:58, Paolo Bonzini wrote:
The scope of set_pte_at_notify() has reduced more and more through the
years. Initially, it was meant for when the change to the PTE was
not bracketed by mmu_notifier_invalidate_range_{start,end}(). However,
that has not been so for over ten years. During all this period
the only implementation of .change_pte() was KVM and it
had no actual functionality, because it was called after
mmu_notifier_invalidate_range_start() zapped the secondary PTE.
Now that this (nonfunctional) user of the .change_pte() callback is
gone, the whole callback can be removed. For now, leave in place
set_pte_at_notify() even though it is just a synonym for set_pte_at().
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---Reviewed-by: David Hildenbrand <redacted> -- Cheers, David / dhildenb