On 05/03/2024 07.29, Nicholas Piggin wrote:

On Tue Feb 27, 2024 at 6:50 PM AEST, Thomas Huth wrote:

quoted

On 26/02/2024 11.11, Nicholas Piggin wrote:

...

quoted

quoted

   	/* save DTB pointer */
-	std	r3, 56(r1)
+	SAVE_GPR(3,r1)

Isn't SAVE_GPR rather meant for the interrupt frame, not for the normal C
calling convention frames?

Sorry for asking dumb questions ... I still have a hard time understanding
the changes here... :-/

Ah, that was me being lazy and using an interrupt frame for the new
frame.

Ah, ok. It's super-confusing (at least for me) to see an interrupt frame 
here out of no reason... could you please either add proper comments here 
explaining this, or even better switch to a normal stack frame, please?

  Thanks,
   Thomas