Thread (20 messages) 20 messages, 3 authors, 2024-04-02

Re: [PATCH v11 00/11] Support page table check PowerPC

From: Ingo Molnar <mingo@kernel.org>
Date: 2024-03-28 09:28:25
Also in: linux-arm-kernel, linux-mm, linux-riscv

* Rohan McLure [off-list ref] wrote:
Rohan McLure (11):
  Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_set"
  Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_set"
  Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pud_clear"
  Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pmd_clear"
  Revert "mm/page_table_check: remove unused parameter in [__]page_table_check_pte_clear"
Just a process request: please give these commits proper titles, they 
are not really 'reverts' in the classical sense, and this title hides 
what is being done in the commit. The typical use of reverts is to 
revert a bad change because it broke something. Here the goal is to 
reintroduce functionality.

So please name these 5 patches accordingly, to shed light on what is 
being reintroduced. You can mention it at the end of the changelog that 
it's a functional revert of commit XYZ, but that's not the primary 
purpose of the commit.

Thanks,

	Ingo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help