Thread (3 messages) 3 messages, 3 authors, 2024-03-25

Re: [PATCH 1/1] ASoC: fsl: fsl_ssi: Add dev_err_probe if PCM DMA init fails

From: Shengjiu Wang <shengjiu.wang@gmail.com>
Date: 2024-03-21 03:31:01
Also in: alsa-devel, linux-sound, lkml

On Thu, Mar 14, 2024 at 10:16 PM Alexander Stein
[off-list ref] wrote:
This happens especially if this driver is built-in, but SDMA driver
is configured as module.

Signed-off-by: Alexander Stein <redacted>
Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>

Best Regards
Shengjiu Wang
quoted hunk ↗ jump to hunk
---
 sound/soc/fsl/fsl_ssi.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
index ab6ec1974807..4ca3a16f7ac0 100644
--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -1401,8 +1401,10 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev,
                        goto error_pcm;
        } else {
                ret = imx_pcm_dma_init(pdev);
-               if (ret)
+               if (ret) {
+                       dev_err_probe(dev, ret, "Failed to init PCM DMA\n");
                        goto error_pcm;
+               }
        }

        return 0;
--
2.34.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help