On 3/14/24 08:31, Christophe Leroy wrote:

Le 14/03/2024 à 16:21, Guenter Roeck a écrit :

quoted

On Wed, Nov 15, 2023 at 03:39:43PM +0100, Herve Codina wrote:

quoted

The QMC HDLC driver provides support for HDLC using the QMC (QUICC
Multichannel Controller) to transfer the HDLC data.

Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Christophe Leroy <redacted>
Acked-by: Jakub Kicinski <kuba@kernel.org>
---

[ ... ]

quoted

+
+static const struct of_device_id qmc_hdlc_id_table[] = {
+	{ .compatible = "fsl,qmc-hdlc" },
+	{} /* sentinel */
+};
+MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);

I am a bit puzzled. How does this even compile ?

Because

#else  /* !MODULE */
#define MODULE_DEVICE_TABLE(type, name)
#endif

Ah, makes sense. We live and learn.

We should probably try to catch those errors when CONFIG_MODULE is not set.

By the way, a fix is available at
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20240314123346.461350-1-herve.codina@bootlin.com/

Great, I'll add that to my testing branch for the time being.

Thanks!
Guenter