Re: [PATCH v3] powerpc: macio: Make remove callback of macio driver void returned

From
Michael Ellerman <mpe@ellerman.id.au>
Date
2024-03-07 12:32:18
Also in
alsa-devel, linux-ide, linux-scsi, linux-serial, linux-wireless, lkml, netdev
Reply to
Dawei Li, 2024-03-06
Dawei Li [off-list ref] writes:
Hi Christophe,

On Tue, Feb 20, 2024 at 04:12:17PM +0000, Christophe Leroy wrote:
quoted
Hi Michael,

ping ?

Le 01/02/2023 à 15:36, Dawei Li a écrit :
quoted
Commit fc7a6209d571 ("bus: Make remove callback return void") forces
bus_type::remove be void-returned, it doesn't make much sense for any
bus based driver implementing remove callbalk to return non-void to
its caller.

This change is for macio bus based drivers.

Signed-off-by: Dawei Li <redacted>
This patch is Acked , any special reason for not applying it ?

Note that it now conflicts with commit 1535d5962d79 ("wifi: remove 
orphaned orinoco driver") but resolution is trivial, just drop the 
changes to that file.
Thanks for picking it up, hardly believe that it's been one year.

Michael,

I will respin V4 if it's needed.
No that's fine, I'll sort it out.

cheers
Thread (7 messages) 7 messages, 6 authors, last reply 2024-03-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help