Re: [PATCH v2 2/3] macintosh/via-pmu-backlight: Include <linux/backlight.h>
From: Jani Nikula <hidden>
Date: 2024-03-05 09:13:31
Also in:
dri-devel, linux-fbdev, lkml
On Tue, 05 Mar 2024, Thomas Zimmermann [off-list ref] wrote:
Fix builds with CONFIG_PMAC_BACKLIGHT=y. The include statement for the backlight header has recently been removed from <linux/fb.h>. Add it to via-pmu-backlight.c to get the necessary symbols. Reported-by: Naresh Kamboju <redacted> Closes: https://lore.kernel.org/dri-devel/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com/ (local) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Fixes: 11b4eedfc87d ("fbdev: Do not include <linux/backlight.h> in header") Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Jani Nikula <redacted> Cc: Helge Deller <deller@gmx.de> Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Jani Nikula <redacted>
quoted hunk ↗ jump to hunk
--- drivers/macintosh/via-pmu-backlight.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/macintosh/via-pmu-backlight.c b/drivers/macintosh/via-pmu-backlight.c index c2d87e7fa85be..89450645c2305 100644 --- a/drivers/macintosh/via-pmu-backlight.c +++ b/drivers/macintosh/via-pmu-backlight.c@@ -10,6 +10,7 @@ #include <asm/ptrace.h> #include <linux/adb.h> +#include <linux/backlight.h> #include <linux/pmu.h> #include <asm/backlight.h>
-- Jani Nikula, Intel