Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h
From: Jani Nikula <hidden>
Date: 2024-03-04 10:01:50
Also in:
dri-devel, linux-fbdev, lkml
On Mon, 04 Mar 2024, Jani Nikula [off-list ref] wrote:
Removal of the backlight include from fb.h uncovered an implicit dependency in powerpc asm/backlight.h. Add the explicit include. Reported-by: Naresh Kamboju <redacted> Closes: https://lore.kernel.org/r/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com (local) Fixes: 11b4eedfc87d ("fbdev: Do not include <linux/backlight.h> in header") Cc: Thomas Zimmermann <tzimmermann@suse.de> Cc: Helge Deller <deller@gmx.de> Cc: linux-fbdev@vger.kernel.org Signed-off-by: Jani Nikula <redacted> --- Not even compile tested!
Naresh, please try this patch! Michael, if this is fine by you, ack to merge via the drm subsystem along with the regressing commit? BR, Jani.
quoted hunk ↗ jump to hunk
--- arch/powerpc/include/asm/backlight.h | 1 + 1 file changed, 1 insertion(+)diff --git a/arch/powerpc/include/asm/backlight.h b/arch/powerpc/include/asm/backlight.h index 1b5eab62ed04..275d5bb9aa04 100644 --- a/arch/powerpc/include/asm/backlight.h +++ b/arch/powerpc/include/asm/backlight.h@@ -10,6 +10,7 @@ #define __ASM_POWERPC_BACKLIGHT_H #ifdef __KERNEL__ +#include <linux/backlight.h> #include <linux/fb.h> #include <linux/mutex.h>
-- Jani Nikula, Intel