Re: [PATCH v2 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing

[PATCH v2 00/13] mm/gup: Unify hugetlb, part 2 · peterx@redhat.com · 2024-01-03
[PATCH v2 01/13] mm/Kconfig: CONFIG_PGTABLE_HAS_HUGE_LEAVES · peterx@redhat.com · 2024-01-03
Re: [PATCH v2 01/13] mm/Kconfig: CONFIG_PGTABLE_HAS_HUGE_LEAVES · Jason Gunthorpe <jgg@nvidia.com> · 2024-01-15
Re: [PATCH v2 01/13] mm/Kconfig: CONFIG_PGTABLE_HAS_HUGE_LEAVES · Peter Xu <peterx@redhat.com> · 2024-01-22
[PATCH v2 02/13] mm/hugetlb: Declare hugetlbfs_pagecache_present() non-static · peterx@redhat.com · 2024-01-03
[PATCH v2 03/13] mm: Provide generic pmd_thp_or_huge() · peterx@redhat.com · 2024-01-03
Re: [PATCH v2 03/13] mm: Provide generic pmd_thp_or_huge() · Jason Gunthorpe <jgg@nvidia.com> · 2024-01-15
Re: [PATCH v2 03/13] mm: Provide generic pmd_thp_or_huge() · Peter Xu <peterx@redhat.com> · 2024-02-21
Re: [PATCH v2 03/13] mm: Provide generic pmd_thp_or_huge() · Jason Gunthorpe <jgg@nvidia.com> · 2024-02-21
Re: [PATCH v2 03/13] mm: Provide generic pmd_thp_or_huge() · Peter Xu <peterx@redhat.com> · 2024-02-22
[PATCH v2 04/13] mm: Make HPAGE_PXD_* macros even if !THP · peterx@redhat.com · 2024-01-03
Re: [PATCH v2 04/13] mm: Make HPAGE_PXD_* macros even if !THP · Jason Gunthorpe <jgg@nvidia.com> · 2024-01-15
[PATCH v2 05/13] mm: Introduce vma_pgtable_walk_{begin|end}() · peterx@redhat.com · 2024-01-03
[PATCH v2 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing · peterx@redhat.com · 2024-01-03
Re: [PATCH v2 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing · Jason Gunthorpe <jgg@nvidia.com> · 2024-01-15
Re: [PATCH v2 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing · Christophe Leroy <hidden> · 2024-01-16
Re: [PATCH v2 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing · Jason Gunthorpe <jgg@nvidia.com> · 2024-01-16
Re: [PATCH v2 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing · Christophe Leroy <hidden> · 2024-01-16
Re: [PATCH v2 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing · Jason Gunthorpe <jgg@nvidia.com> · 2024-01-17
Re: [PATCH v2 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing · Ryan Roberts <ryan.roberts@arm.com> · 2024-01-18
Re: [PATCH v2 06/13] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing · Peter Xu <peterx@redhat.com> · 2024-02-21
[PATCH v2 07/13] mm/gup: Refactor record_subpages() to find 1st small page · peterx@redhat.com · 2024-01-03
Re: [PATCH v2 07/13] mm/gup: Refactor record_subpages() to find 1st small page · Jason Gunthorpe <jgg@nvidia.com> · 2024-01-15
[PATCH v2 08/13] mm/gup: Handle hugetlb for no_page_table() · peterx@redhat.com · 2024-01-03
Re: [PATCH v2 08/13] mm/gup: Handle hugetlb for no_page_table() · Jason Gunthorpe <jgg@nvidia.com> · 2024-01-15
[PATCH v2 09/13] mm/gup: Cache *pudp in follow_pud_mask() · peterx@redhat.com · 2024-01-03
Re: [PATCH v2 09/13] mm/gup: Cache *pudp in follow_pud_mask() · Jason Gunthorpe <jgg@nvidia.com> · 2024-01-15
[PATCH v2 10/13] mm/gup: Handle huge pud for follow_pud_mask() · peterx@redhat.com · 2024-01-03
Re: [PATCH v2 10/13] mm/gup: Handle huge pud for follow_pud_mask() · Jason Gunthorpe <jgg@nvidia.com> · 2024-01-15
Re: [PATCH v2 10/13] mm/gup: Handle huge pud for follow_pud_mask() · Peter Xu <peterx@redhat.com> · 2024-02-21
[PATCH v2 11/13] mm/gup: Handle huge pmd for follow_pmd_mask() · peterx@redhat.com · 2024-01-03
Re: [PATCH v2 11/13] mm/gup: Handle huge pmd for follow_pmd_mask() · Jason Gunthorpe <jgg@nvidia.com> · 2024-01-15
[PATCH v2 12/13] mm/gup: Handle hugepd for follow_page() · peterx@redhat.com · 2024-01-03
[PATCH v2 13/13] mm/gup: Handle hugetlb in the generic follow_page_mask code · peterx@redhat.com · 2024-01-03
Re: [PATCH v2 00/13] mm/gup: Unify hugetlb, part 2 · Christophe Leroy <hidden> · 2024-01-03
Re: [PATCH v2 00/13] mm/gup: Unify hugetlb, part 2 · Peter Xu <peterx@redhat.com> · 2024-01-08

From: Peter Xu <peterx@redhat.com>
Date: 2024-02-21 11:55:33
Also in: linux-arm-kernel, linux-mm, linux-riscv, lkml

On Mon, Jan 15, 2024 at 02:37:48PM -0400, Jason Gunthorpe wrote:

quoted

Drop that check, not only because it'll never be true for hugepd per any
known plan, but also it paves way for reusing the function outside
fast-gup.

I didn't see any other caller of this function in this series? When
does this re-use happen??

It's reused in patch 12 ("mm/gup: Handle hugepd for follow_page()").

Thanks,

-- 
Peter Xu

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help