Thread (32 messages) 32 messages, 4 authors, 2024-02-22

Re: [PATCH v3 RESEND 1/6] net: wan: Add support for QMC HDLC

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2024-02-12 12:23:05
Also in: lkml, netdev

On Mon, Feb 12, 2024 at 08:56:29AM +0100, Herve Codina wrote:
The QMC HDLC driver provides support for HDLC using the QMC (QUICC
Multichannel Controller) to transfer the HDLC data.
...
+#include <linux/dma-mapping.h>
+#include <linux/hdlc.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_platform.h>
I do not see how these are being used, am I right?
What's is missing OTOH is the mod_devicetable.h.
+#include <linux/platform_device.h>
+#include <linux/slab.h>
+ Blank line?
+#include <soc/fsl/qe/qmc.h>
-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help