powerpc/iommu: Code cleanup for cell/iommu.c

Started by Kunwu Chan on Jan 25, 2024 · 3 messages from 2 authors · Last reply Jan 25, 2024

Subsystems (3)

Maintainers (2)

STALE1021d

open the first message on its own page

Message details and related content
This part was commented from commit 165785e5c0be ("[POWERPC] Cell
iommu support") in about 17 years before.

If there are no plans to enable this part code in the future,
we can remove this dead code.

Signed-off-by: Kunwu Chan <redacted>
---
 arch/powerpc/platforms/cell/iommu.c | 16 ----------------
 1 file changed, 16 deletions(-)
diff --git a/arch/powerpc/platforms/cell/iommu.c b/arch/powerpc/platforms/cell/iommu.c
index 1202a69b0a20..afce9e64a443 100644
--- a/arch/powerpc/platforms/cell/iommu.c
+++ b/arch/powerpc/platforms/cell/iommu.c
@@ -424,22 +424,6 @@ static void __init cell_iommu_setup_hardware(struct cbe_iommu *iommu,
 	cell_iommu_enable_hardware(iommu);
 }
 
-#if 0/* Unused for now */
-static struct iommu_window *find_window(struct cbe_iommu *iommu,
-		unsigned long offset, unsigned long size)
-{
-	struct iommu_window *window;
-
-	/* todo: check for overlapping (but not equal) windows) */
-
-	list_for_each_entry(window, &(iommu->windows), list) {
-		if (window->offset == offset && window->size == size)
-			return window;
-	}
-
-	return NULL;
-}
-#endif
 
 static inline u32 cell_iommu_get_ioid(struct device_node *np)
 {
-- 
2.39.2
Message details and related content

Le 25/01/2024 à 03:46, Kunwu Chan a écrit :
quoted hunk
This part was commented from commit 165785e5c0be ("[POWERPC] Cell
iommu support") in about 17 years before.

If there are no plans to enable this part code in the future,
we can remove this dead code.

Signed-off-by: Kunwu Chan <redacted>
---
  arch/powerpc/platforms/cell/iommu.c | 16 ----------------
  1 file changed, 16 deletions(-)
diff --git a/arch/powerpc/platforms/cell/iommu.c b/arch/powerpc/platforms/cell/iommu.c
index 1202a69b0a20..afce9e64a443 100644
--- a/arch/powerpc/platforms/cell/iommu.c
+++ b/arch/powerpc/platforms/cell/iommu.c
@@ -424,22 +424,6 @@ static void __init cell_iommu_setup_hardware(struct cbe_iommu *iommu,
  	cell_iommu_enable_hardware(iommu);
  }
  
-#if 0/* Unused for now */
-static struct iommu_window *find_window(struct cbe_iommu *iommu,
-		unsigned long offset, unsigned long size)
-{
-	struct iommu_window *window;
-
-	/* todo: check for overlapping (but not equal) windows) */
-
-	list_for_each_entry(window, &(iommu->windows), list) {
-		if (window->offset == offset && window->size == size)
-			return window;
-	}
-
-	return NULL;
-}
-#endif
Same as the other one, please remove the second blank line, don't leave 
two blank lines between the remaining functions.
  
  static inline u32 cell_iommu_get_ioid(struct device_node *np)
  {
Message details and related content
On 2024/1/25 14:49, Christophe Leroy wrote:

Le 25/01/2024 à 03:46, Kunwu Chan a écrit :
quoted
This part was commented from commit 165785e5c0be ("[POWERPC] Cell
iommu support") in about 17 years before.

If there are no plans to enable this part code in the future,
we can remove this dead code.

Signed-off-by: Kunwu Chan <redacted>
---
   arch/powerpc/platforms/cell/iommu.c | 16 ----------------
   1 file changed, 16 deletions(-)
diff --git a/arch/powerpc/platforms/cell/iommu.c b/arch/powerpc/platforms/cell/iommu.c
index 1202a69b0a20..afce9e64a443 100644
--- a/arch/powerpc/platforms/cell/iommu.c
+++ b/arch/powerpc/platforms/cell/iommu.c
@@ -424,22 +424,6 @@ static void __init cell_iommu_setup_hardware(struct cbe_iommu *iommu,
   	cell_iommu_enable_hardware(iommu);
   }
   
-#if 0/* Unused for now */
-static struct iommu_window *find_window(struct cbe_iommu *iommu,
-		unsigned long offset, unsigned long size)
-{
-	struct iommu_window *window;
-
-	/* todo: check for overlapping (but not equal) windows) */
-
-	list_for_each_entry(window, &(iommu->windows), list) {
-		if (window->offset == offset && window->size == size)
-			return window;
-	}
-
-	return NULL;
-}
-#endif
Same as the other one, please remove the second blank line, don't leave

1 more quoted lines

Thanks for your reply.

I'll check my patches and update in v2.
quoted
   
   static inline u32 cell_iommu_get_ioid(struct device_node *np)
   {
-- 
Thanks,
  Kunwu
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help