Re: [PATCH 3/3] powerpc: ps3: Add missing set_freezable() for ps3_probe_thread()
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2023-12-21 11:18:31
From: Michael Ellerman <mpe@ellerman.id.au>
Date: 2023-12-21 11:18:31
Geoff Levand [off-list ref] writes:
Hi Kevin, On 12/21/23 13:45, Kevin Hao wrote:quoted
The kernel thread function ps3_probe_thread() invokes the try_to_freeze() in its loop. But all the kernel threads are non-freezable by default. So if we want to make a kernel thread to be freezable, we have to invoke set_freezable() explicitly. Signed-off-by: Kevin Hao <redacted> --- arch/powerpc/platforms/ps3/device-init.c | 1 + 1 file changed, 1 insertion(+)diff --git a/arch/powerpc/platforms/ps3/device-init.c b/arch/powerpc/platforms/ps3/device-init.c index e87360a0fb40..878bc160246e 100644 --- a/arch/powerpc/platforms/ps3/device-init.c +++ b/arch/powerpc/platforms/ps3/device-init.c@@ -827,6 +827,7 @@ static int ps3_probe_thread(void *data) if (res) goto fail_free_irq; + set_freezable(); /* Loop here processing the requested notification events. */ do { try_to_freeze();Seems like a reasonable addition. Signed-off-by: Geoff Levand <geoff@infradead.org>
I turned that into an Acked-by, which I think is what you meant :) cheers