Thread (15 messages) 15 messages, 5 authors, 2024-01-02

Re: [PATCH 3/3] PCI/AER: Use explicit register sizes for struct members

From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Date: 2023-12-08 14:39:18
Also in: linux-pci, lkml

On Wed,  6 Dec 2023 16:42:31 -0600
Bjorn Helgaas [off-list ref] wrote:
From: Bjorn Helgaas <bhelgaas@google.com>

aer_irq() reads the AER Root Error Status and Error Source Identification
(PCI_ERR_ROOT_STATUS and PCI_ERR_ROOT_ERR_SRC) registers directly into
struct aer_err_source.  Both registers are 32 bits, so declare the members
explicitly as "u32" instead of "unsigned int".

Similarly, aer_get_device_error_info() reads the AER Header Log
(PCI_ERR_HEADER_LOG) registers, which are also 32 bits, into struct
aer_header_log_regs.  Declare those members as "u32" as well.

No functional changes intended.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Another sensible cleanup. FWIW on such simple patches
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help