Re: [PATCH v2] i2c: cpm: Remove linux,i2c-index conversion from be32
From: Jochen Friedrich <jochen@scram.de>
Date: 2023-12-08 11:27:43
Also in:
linux-i2c, lkml
From: Jochen Friedrich <jochen@scram.de>
Date: 2023-12-08 11:27:43
Also in:
linux-i2c, lkml
Acked-By: Jochen Friedrich <jochen@scram.de> Am 06.12.2023 um 23:24 schrieb Christophe Leroy:
sparse reports an error on some data that gets converted from be32. That's because that data is typed u32 instead of __be32. The type is correct, the be32_to_cpu() conversion is not. Remove the conversion. Reported-by: kernel test robot <redacted> Closes: https://lore.kernel.org/oe-kbuild-all/202312042210.QL4DA8Av-lkp@intel.com/ (local) Signed-off-by: Christophe Leroy <redacted> --- v2: Use u32 directly, remove be32_to_cpu(). --- drivers/i2c/busses/i2c-cpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c index 9a664abf734d..771d60bc8d71 100644 --- a/drivers/i2c/busses/i2c-cpm.c +++ b/drivers/i2c/busses/i2c-cpm.c@@ -658,7 +658,7 @@ static int cpm_i2c_probe(struct platform_device *ofdev) /* register new adapter to i2c module... */ data = of_get_property(ofdev->dev.of_node, "linux,i2c-index", &len); - cpm->adap.nr = (data && len == 4) ? be32_to_cpup(data) : -1; + cpm->adap.nr = (data && len == 4) ? *data : -1; result = i2c_add_numbered_adapter(&cpm->adap); if (result < 0)