Hi,

On 12/6/23 08:56, George Stark wrote:

Hello Andy

Thanks for the review.

On 12/4/23 21:11, Andy Shevchenko wrote:

quoted

On Mon, Dec 4, 2023 at 8:07 PM George Stark [off-list ref] wrote:

quoted

Using of devm API leads to certain order of releasing resources.
So all dependent resources which are not devm-wrapped should be deleted
with respect to devm-release order. Mutex is one of such objects that
often is bound to other resources and has no own devm wrapping.
Since mutex_destroy() actually does nothing in non-debug builds
frequently calling mutex_destroy() is just ignored which is safe for now
but wrong formally and can lead to a problem if mutex_destroy() is
extended so introduce devm_mutex_init().

...

Do you need to include mutex.h?

It's already included in linux/device.h which is included in devm-helpers. Should I include mutex.h explicitly?

Yes you must explicitly include all headers you use definitions
from. Relying on other headers to do this for you is error prone.

Regards,

Hans