Thread (2 messages) flat view 2 messages, 2 authors, 2023-12-06

Re: [PATCH 12/27] tty: hvc: convert to u8 and size_t

From: Christophe Leroy <hidden>
Date: 2023-12-06 09:30:55
Also in: linux-riscv, linux-serial, lkml, virtualization


Le 06/12/2023 à 08:36, Jiri Slaby (SUSE) a écrit :
quoted hunk ↗ jump to hunk
Switch character types to u8 and sizes to size_t. To conform to
characters/sizes in the rest of the tty layer.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Christophe Leroy <redacted>
Cc: Amit Shah <amit@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Paul Walmsley <redacted>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: linuxppc-dev@lists.ozlabs.org
Cc: virtualization@lists.linux.dev
Cc: linux-riscv@lists.infradead.org
---
  arch/powerpc/include/asm/hvconsole.h       |  4 ++--
  arch/powerpc/include/asm/hvsi.h            | 18 ++++++++--------
  arch/powerpc/include/asm/opal.h            |  8 +++++---
  arch/powerpc/platforms/powernv/opal.c      | 14 +++++++------
  arch/powerpc/platforms/pseries/hvconsole.c |  4 ++--
  drivers/char/virtio_console.c              | 10 ++++-----
  drivers/tty/hvc/hvc_console.h              |  4 ++--
  drivers/tty/hvc/hvc_dcc.c                  | 24 +++++++++++-----------
  drivers/tty/hvc/hvc_iucv.c                 | 18 ++++++++--------
  drivers/tty/hvc/hvc_opal.c                 |  5 +++--
  drivers/tty/hvc/hvc_riscv_sbi.c            |  9 ++++----
  drivers/tty/hvc/hvc_rtas.c                 | 11 +++++-----
  drivers/tty/hvc/hvc_udbg.c                 |  9 ++++----
  drivers/tty/hvc/hvc_vio.c                  | 18 ++++++++--------
  drivers/tty/hvc/hvc_xen.c                  | 23 +++++++++++----------
  drivers/tty/hvc/hvsi_lib.c                 | 20 ++++++++++--------
  16 files changed, 107 insertions(+), 92 deletions(-)
diff --git a/arch/powerpc/include/asm/hvconsole.h b/arch/powerpc/include/asm/hvconsole.h
index ccb2034506f0..d841a97010a0 100644
--- a/arch/powerpc/include/asm/hvconsole.h
+++ b/arch/powerpc/include/asm/hvconsole.h
@@ -21,8 +21,8 @@
   * Vio firmware always attempts to fetch MAX_VIO_GET_CHARS chars.  The 'count'
   * parm is included to conform to put_chars() function pointer template
   */
-extern int hvc_get_chars(uint32_t vtermno, char *buf, int count);
-extern int hvc_put_chars(uint32_t vtermno, const char *buf, int count);
+extern ssize_t hvc_get_chars(uint32_t vtermno, u8 *buf, size_t count);
+extern ssize_t hvc_put_chars(uint32_t vtermno, const u8 *buf, size_t count);
Would be a good opportunity to drop this pointless deprecated 'extern' 
keyword on all function prototypes you are changing.

Christophe
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help