On Thu, Nov 30, 2023, at 07:43, Michael Ellerman wrote:

"Arnd Bergmann" [off-list ref] writes:

quoted

On Wed, Nov 29, 2023, at 14:19, Michael Ellerman wrote:

quoted

diff --git a/arch/powerpc/mm/mmu_decl.h b/arch/powerpc/mm/mmu_decl.h
index 7f9ff0640124..72341b9fb552 100644
--- a/arch/powerpc/mm/mmu_decl.h
+++ b/arch/powerpc/mm/mmu_decl.h
+
+#ifdef CONFIG_MEMORY_HOTPLUG
+int create_section_mapping(unsigned long start, unsigned long end,
+			   int nid, pgprot_t prot);
+#endif

This one should probably go next to the remove_section_mapping()
declaration in arch/powerpc/include/asm/sparsemem.h for consistency.

That doesn't work due to:

In file included from ../include/linux/numa.h:26,
                 from ../include/linux/async.h:13,
                 from ../init/initramfs.c:3:
../arch/powerpc/include/asm/sparsemem.h:19:44: error: unknown type name 
‘pgprot_t’
   19 |                                   int nid, pgprot_t prot);
      |                                            ^~~~~~~~

Which might be fixable, but I'd rather just move
remove_section_mapping() into mmu_decl.h as well.

Ok, makes sense.

     Arnd