Thread (9 messages) 9 messages, 4 authors, 2023-11-28

Re: [linus:master] [file] 0ede61d858: will-it-scale.per_thread_ops -2.9% regression

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: 2023-11-26 23:21:19
Also in: bpf, gfs2, intel-gfx, linux-doc, linux-fsdevel, lkml, oe-lkp

On Sun, 26 Nov 2023 at 12:23, Linus Torvalds
[off-list ref] wrote:
IOW, I might have messed up some "trivial cleanup" when prepping for
sending it out...
Bah. Famous last words. One of the "trivial cleanups" made the code
more "obvious" by renaming the nospec mask as just "mask".

And that trivial rename broke that patch *entirely*, because now that
name shadowed the "fmode_t" mask argument.

Don't even ask how long it took me to go from "I *tested* this,
dammit, now it doesn't work at all" to "Oh God, I'm so stupid".

So that nobody else would waste any time on this, attached is a new
attempt. This time actually tested *after* the changes.

                  Linus

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help