Re: [PATCH v2 2/4] eventfd: simplify eventfd_signal()
From: Jani Nikula <jani.nikula@linux.intel.com>
Date: 2023-11-22 15:19:34
Also in:
cgroups, dri-devel, intel-gfx, io-uring, kvm, linux-fpga, linux-fsdevel, linux-mm, linux-rdma, linux-s390, linux-usb, lkml, netdev, virtualization
On Wed, 22 Nov 2023, Christian Brauner [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/fs/eventfd.c b/fs/eventfd.c index 33a918f9566c..dc9e01053235 100644 --- a/fs/eventfd.c +++ b/fs/eventfd.c@@ -74,20 +74,17 @@ __u64 eventfd_signal_mask(struct eventfd_ctx *ctx, __u64 n, __poll_t mask) /** * eventfd_signal - Adds @n to the eventfd counter.
This still refers to @n here, and in patch 4. BR, Jani.
* @ctx: [in] Pointer to the eventfd context.
- * @n: [in] Value of the counter to be added to the eventfd internal counter.
- * The value cannot be negative.
*
* This function is supposed to be called by the kernel in paths that do not
* allow sleeping. In this function we allow the counter to reach the ULLONG_MAX
* value, and we signal this as overflow condition by returning a EPOLLERR
* to poll(2).
*
- * Returns the amount by which the counter was incremented. This will be less
- * than @n if the counter has overflowed.
+ * Returns the amount by which the counter was incremented.
*/
-__u64 eventfd_signal(struct eventfd_ctx *ctx, __u64 n)
+__u64 eventfd_signal(struct eventfd_ctx *ctx)
{
- return eventfd_signal_mask(ctx, n, 0);
+ return eventfd_signal_mask(ctx, 1, 0);
}
EXPORT_SYMBOL_GPL(eventfd_signal);
-- Jani Nikula, Intel