Thread (3 messages) flat view 3 messages, 3 authors, 2023-12-07

Re: [PATCH] misc: ocxl: main: Remove unnecessary‘0’ values from rc

From: Andrew Donnellan <hidden>
Date: 2023-11-20 04:19:52
Also in: lkml

On Mon, 2023-11-13 at 09:52 +0800, Li kunyu wrote:
rc is assigned first, so it does not need to initialize the
assignment.

Signed-off-by: Li kunyu <redacted>
I don't have strong feelings about whether to get rid of unnecessary
initialisations, but most of the code doesn't do it, so for
consistency:

Acked-by: Andrew Donnellan <redacted>
quoted hunk ↗ jump to hunk
---
 drivers/misc/ocxl/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/ocxl/main.c b/drivers/misc/ocxl/main.c
index ef73cf35dda2b..658974143c3cc 100644
--- a/drivers/misc/ocxl/main.c
+++ b/drivers/misc/ocxl/main.c
@@ -7,7 +7,7 @@
 
 static int __init init_ocxl(void)
 {
-	int rc = 0;
+	int rc;
 
 	if (!tlbie_capable)
 		return -EINVAL;
-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@linux.ibm.com   IBM Australia Limited
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help