Re: [PATCH v2 5/8] RISC-V: Add inline version of sbi_console_putchar/getchar() functions
From: Andrew Jones <hidden>
Date: 2023-10-19 08:04:02
Also in:
kvm, kvm-riscv, linux-riscv, linux-serial, lkml
On Thu, Oct 12, 2023 at 10:45:06AM +0530, Anup Patel wrote:
The functions sbi_console_putchar() and sbi_console_getchar() are not defined when CONFIG_RISCV_SBI_V01 is disabled so let us add inline version of these functions to avoid "#ifdef" on user side.
nit: Here and in the summary I'd probably use the word "stub" instead of "inline version".
quoted hunk ↗ jump to hunk
Signed-off-by: Anup Patel <redacted> --- arch/riscv/include/asm/sbi.h | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/arch/riscv/include/asm/sbi.h b/arch/riscv/include/asm/sbi.h index 12dfda6bb924..cbcefa344417 100644 --- a/arch/riscv/include/asm/sbi.h +++ b/arch/riscv/include/asm/sbi.h@@ -271,8 +271,13 @@ struct sbiret sbi_ecall(int ext, int fid, unsigned long arg0, unsigned long arg3, unsigned long arg4, unsigned long arg5); +#ifdef CONFIG_RISCV_SBI_V01 void sbi_console_putchar(int ch); int sbi_console_getchar(void); +#else +static inline void sbi_console_putchar(int ch) { } +static inline int sbi_console_getchar(void) { return -1; } +#endif long sbi_get_mvendorid(void); long sbi_get_marchid(void); long sbi_get_mimpid(void);-- 2.34.1
Otherwise, Reviewed-by: Andrew Jones <redacted>