Re: [PATCH 04/15] tty: Remove now superfluous sentinel element from ctl_table array
From: Jiri Slaby <jirislaby@kernel.org>
Date: 2023-10-02 08:17:58
Also in:
dri-devel, intel-gfx, linux-hyperv, linux-raid, linux-rdma, linux-scsi, linux-serial, lkml, netdev, xen-devel
On 28. 09. 23, 15:21, Joel Granados via B4 Relay wrote:
quoted hunk ↗ jump to hunk
From: Joel Granados <redacted> This commit comes at the tail end of a greater effort to remove the empty elements at the end of the ctl_table arrays (sentinels) which will reduce the overall build time size of the kernel and run time memory bloat by ~64 bytes per sentinel (further information Link : https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/ (local)) Remove sentinel from tty_table Signed-off-by: Joel Granados <redacted> --- drivers/tty/tty_io.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c index 8a94e5a43c6d..2f925dc54a20 100644 --- a/drivers/tty/tty_io.c +++ b/drivers/tty/tty_io.c@@ -3607,8 +3607,7 @@ static struct ctl_table tty_table[] = { .proc_handler = proc_dointvec, .extra1 = SYSCTL_ZERO, .extra2 = SYSCTL_ONE, - }, - { } + }
Why to remove the comma? One would need to add one when adding a new entry? thanks, -- js suse labs