Re: [PATCH] powerpc: add `cur_cpu_spec` symbol to vmcoreinfo
From: Aditya Gupta <hidden>
Date: 2023-09-14 06:19:01
Hello Sachin, On Wed, Sep 13, 2023 at 06:19:11PM +0530, Sachin Sant wrote:
quoted
On 11-Sep-2023, at 2:44 PM, Aditya Gupta [off-list ref] wrote: Presently, while reading a vmcore, makedumpfile uses `cur_cpu_spec.mmu_features` to decide whether the crashed system had RADIX MMU or not. Currently, makedumpfile fails to get the `cur_cpu_spec` symbol (unless a vmlinux is passed with the `-x` flag to makedumpfile), and hence assigns offsets and shifts (such as pgd_offset_l4) incorrecly considering MMU to be hash MMU. Add `cur_cpu_spec` symbol and offset of `mmu_features` in the `cpu_spec` struct, to VMCOREINFO, so that the symbol address and offset is accessible to makedumpfile, without needing the vmlinux file Signed-off-by: Aditya Gupta <redacted> ---Thanks for the patch. With this patch applied (along with makedumpfile changes) I am able to capture vmcore against a kernel which contains commit 8dc9a0ad0c3e Reported-by: Sachin Sant <redacted> Tested-by: Sachin Sant <redacted>
Thanks for testing this, and for providing the tags. - Aditya Gupta