Re: Fwd: [PATCH] powerpc/ptrace: Fix buffer overflow when handling PTRACE_PEEKUSER and PTRACE_POKEUSER
From: Ariel Miculas <hidden>
Date: 2023-09-27 19:35:43
Also in:
lkml
From: Ariel Miculas <hidden>
Date: 2023-09-27 19:35:43
Also in:
lkml
On Wed, Sep 27, 2023 at 7:01 PM Christophe Leroy [off-list ref] wrote:
Le 27/09/2023 à 17:27, Ariel Miculas a écrit :quoted
I've forwarded this old email thread for visibility and discussion's sake around my recent blog post [1][2]Ah, right, it's been superseded by https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220609133245.573565-1-mpe@ellerman.id.au/ So I mark the new one superseded as well. By the way, is your other patch still applicable, ref https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220610102821.252729-1-ariel.miculas@belden.com/ ?
Well, I think it's better to explicitly access fpscr than to implicitly overflow fpr into fpscr. Because in the implicit case you need to make sure fpscr comes directly after fpr and this relationship is never modified (e.g. someone refactors the code and puts fpscr before fpr). Regards, Ariel
Thanks Christophe