Thread (3 messages) 3 messages, 2 authors, 2023-09-26

Re: [PATCH v2 1/1] PCI: layerscape-ep: set 64-bit DMA mask

From: Frank Li <Frank.li@nxp.com>
Date: 2023-09-26 14:00:39
Also in: imx, linux-arm-kernel, linux-pci, lkml

On Tue, Sep 26, 2023 at 12:27:32AM -0700, Christoph Hellwig wrote:
quoted
+	/* set 64-bit DMA mask and coherent DMA mask */
+	ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64));
The comment is a bit silly :)
quoted
+	if (ret)
+		return ret;
Also no need to check the return value when setting a 64-bit mask,
but I guess it desn't hurt here.
You are right, let me remove check.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help