Thread (67 messages) 67 messages, 2 authors, 2023-08-16

Re: [PATCH v6 07/25] iommu/mtk_iommu_v1: Implement an IDENTITY domain

From: Baolu Lu <baolu.lu@linux.intel.com>
Date: 2023-08-15 00:35:19
Also in: linux-arm-kernel, linux-arm-msm, linux-iommu, linux-mediatek, linux-rockchip, linux-s390, linux-samsung-soc, linux-sunxi, linux-tegra 

On 2023/8/14 22:34, Jason Gunthorpe wrote:
quoted
quoted
@@ -443,7 +459,7 @@ static int mtk_iommu_v1_create_mapping(struct device *dev, struct of_phandle_arg
   static int mtk_iommu_v1_def_domain_type(struct device *dev)
   {
-	return IOMMU_DOMAIN_UNMANAGED;
+	return IOMMU_DOMAIN_IDENTITY;
def_domain_type can't be used for this purpose. But this seems to be a
temporary code, as it will be removed in patch 09/25.
It looked OK when I checked it, mkt_v1 is really confusing what it
tries to do, but it should call probe_finalize and basically do the
same hacky thing as what UNMANAGED was trying to accomplish.

Did you see something else?
No.

Best regards,
baolu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help