Thread (10 messages) 10 messages, 4 authors, 2023-08-31

Re: [PATCH v2 0/2] kbuild: Show Kconfig fragments in "help"

From: Masahiro Yamada <masahiroy@kernel.org>
Date: 2023-08-29 14:58:59
Also in: linux-arm-kernel, linux-hardening, linux-kbuild, linux-riscv, linux-s390, lkml

On Tue, Aug 29, 2023 at 3:55 PM Nicolas Schier [off-list ref] wrote:
On Mon 28 Aug 2023 16:17:07 GMT, Michael Ellerman wrote:
quoted
Masahiro Yamada [off-list ref] writes:
quoted
On Sat, Aug 26, 2023 at 4:55 AM Kees Cook [off-list ref] wrote:
quoted
Hi,

This is my series to show *.config targets in the "help" target so these
various topics can be more easily discoverd.

v2:
 - split .fragment from .config to hide "internal" fragments
Please do not do this churn.
That was my idea :}
quoted
Like Randy, I did not get "why" part quiet well,
but if you are eager about this,
you can show help message only when the following
("# Help:" prefix for example) is found in the first line.

# Help: blah blah
# other comment
I did think of that, but wasn't sure how to do it in make.
Something like this should do it:

        @grep -Hnm1 -e '^# Help:' $(foreach f, $(sort $(notdir $(call configfiles,*.config))), $(firstword $(call configfiles,$(f)))) | \
         while read loc dummy helptext; do \
                tmp="$${loc%:#}"; file="$${tmp%:*}"; line="$${tmp##*:}"; \
                [ "$${line}" = "1" ] && \
                  printf "  %-25s - %s\\n" "$${file##*/}" "$${helptext}"; \
         done

but this neither beautiful nor elegant it likes to be improved.

Kind regards,
Nicolas



The attached patch will work too.

I dropped the "in the first line" restriction
because SPDX might be placed in the first line
of config fragments.



-- 
Best Regards
Masahiro Yamada

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help