Thread (48 messages) 48 messages, 9 authors, 2023-09-20

Re: [PATCH v4 23/28] mfd: core: Ensure disabled devices are skiped without aborting

From: Lee Jones <lee@kernel.org>
Date: 2023-08-21 12:17:33
Also in: alsa-devel, linux-arm-kernel, linux-devicetree, linux-gpio, lkml, netdev

On Fri, 18 Aug 2023, Christophe Leroy wrote:
From: Herve Codina <herve.codina@bootlin.com>

The loop searching for a matching device based on its compatible
string is aborted when a matching disabled device is found.
This abort prevents to add devices as soon as one disabled device
is found.

Continue searching for an other device instead of aborting on the
first disabled one fixes the issue.

Fixes: 22380b65dc70 ("mfd: mfd-core: Ensure disabled devices are ignored without error")
Signed-off-by: Herve Codina <herve.codina@bootlin.com>
Reviewed-by: Christophe Leroy <redacted>
Signed-off-by: Christophe Leroy <redacted>
---
 drivers/mfd/mfd-core.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)
This is too big of a change to be added this late in the cycle.

Pushing review until after v6.5 is out.
-- 
Lee Jones [李琼斯]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help