Re: [PATCH v4 08/10] powerpc/pseries: Initialise CPU hotplug callbacks earlier

From
Srikar Dronamraju <hidden>
Date
2023-08-14 10:52:28
Also in
linux-arch, lkml
Reply to
Laurent Dufour, 2023-07-05
* Laurent Dufour [off-list ref] [2023-07-05 16:51:41]:
From: Michael Ellerman <mpe@ellerman.id.au>

As part of the generic HOTPLUG_SMT code, there is support for disabling
secondary SMT threads at boot time, by passing "nosmt" on the kernel
command line.

The way that is implemented is the secondary threads are brought partly
online, and then taken back offline again. That is done to support x86
CPUs needing certain initialisation done on all threads. However powerpc
has similar needs, see commit d70a54e2d085 ("powerpc/powernv: Ignore
smt-enabled on Power8 and later").

For that to work the powerpc CPU hotplug callbacks need to be registered
before secondary CPUs are brought online, otherwise __cpu_disable()
fails due to smp_ops->cpu_disable being NULL.

So split the basic initialisation into pseries_cpu_hotplug_init() which
can be called early from setup_arch(). The DLPAR related initialisation
can still be done later, because it needs to do allocations.
Looks good to me.

Reviewed-by: Srikar Dronamraju <redacted>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
-- 
Thanks and Regards
Srikar Dronamraju
Thread (24 messages) 24 messages, 6 authors, last reply 2024-04-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help