Re: [PATCH 02/17] [RESEND] irq_work: consolidate arch_irq_work_raise prototypes
flat view
From: Masahiro Yamada <masahiroy@kernel.org>
Date: 2023-08-11 22:11:03
Also in:
linux-arm-kernel, linux-riscv, linux-s390, lkml
On Fri, Aug 11, 2023 at 10:00 AM Arnd Bergmann [off-list ref] wrote:
From: Arnd Bergmann <arnd@arndb.de> The prototype was hidden on x86, which causes a warning:
What do you mean by "hidden on x86"? arch_irq_work_raise() was declared on 7 architectures, including x86.
kernel/irq_work.c:72:13: error: no previous prototype for 'arch_irq_work_raise' [-Werror=missing-prototypes] Fix this by providing it in only one place that is always visible. Acked-by: Catalin Marinas <catalin.marinas@arm.com> Acked-by: Palmer Dabbelt <redacted> Acked-by: Guo Ren <guoren@kernel.org> Reviewed-by: Alexander Gordeev <agordeev@linux.ibm.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/include/asm/irq_work.h | 2 -- arch/arm64/include/asm/irq_work.h | 2 -- arch/csky/include/asm/irq_work.h | 2 +- arch/powerpc/include/asm/irq_work.h | 1 - arch/riscv/include/asm/irq_work.h | 2 +- arch/s390/include/asm/irq_work.h | 2 -- arch/x86/include/asm/irq_work.h | 1 - include/linux/irq_work.h | 3 +++ 8 files changed, 5 insertions(+), 10 deletions(-)
-- Best Regards Masahiro Yamada