Re: [PATCH v3 21/28] net: wan: Add framer framework support

From
Herve Codina <herve.codina@bootlin.com>
Date
2023-08-09 15:01:52
Also in
alsa-devel, linux-arm-kernel, linux-devicetree, linux-gpio, lkml, netdev
Reply to
Randy Dunlap, 2023-08-09
Hi Randy,

On Wed, 9 Aug 2023 07:24:32 -0700
Randy Dunlap [off-list ref] wrote:
Hi,

On 8/9/23 06:27, Herve Codina wrote:
quoted
diff --git a/drivers/net/wan/framer/Kconfig b/drivers/net/wan/framer/Kconfig
new file mode 100644
index 000000000000..96ef1e7ba8eb
--- /dev/null
+++ b/drivers/net/wan/framer/Kconfig
@@ -0,0 +1,19 @@
+# SPDX-License-Identifier: GPL-2.0-only
+#
+# FRAMER
+#
+
+menu "Framer Subsystem"
+
+config GENERIC_FRAMER
+	bool "Framer Core"  
Just curious: any reason that this cannot be tristate (i.e., a loadable module)?
Thanks.
For the same reasons as generic phy cannot be built as module
  b51fbf9fb0c3 phy-core: Don't allow building phy-core as a module

In the framer case, this allows to have the QMC HDLC driver built on systems
without any framers (no providers and no framer core framework).
Also the framer phandle is optional in the device tree QMC HDLC node.

Regards,
Hervé
quoted
+	help
+	  Generic Framer support.
+
+	  This framework is designed to provide a generic interface for framer
+	  devices present in the kernel. This layer will have the generic
+	  API by which framer drivers can create framer using the framer
+	  framework and framer users can obtain reference to the framer.
+	  All the users of this framework should select this config.
+
+endmenu  


-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Thread (37 messages) 37 messages, 5 authors, last reply 2023-08-16
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help