Thread (91 messages) 91 messages, 8 authors, 2023-08-08

Re: [PATCH v2 24/28] pinctrl: Add support for the Lantic PEF2256 pinmux

From: Linus Walleij <hidden>
Date: 2023-08-07 13:05:30
Also in: alsa-devel, linux-arm-kernel, linux-devicetree, linux-gpio, lkml, netdev

Hi Herve,

thanks for your patch!

First: is this patch something we could merge separately? I don't see
any dependency on the other patches.

On Wed, Jul 26, 2023 at 5:04 PM Herve Codina [off-list ref] wrote:
The Lantiq PEF2256 is a framer and line interface component designed to
fulfill all required interfacing between an analog E1/T1/J1 line and the
digital PCM system highway/H.100 bus.

This pinmux support handles the pin muxing part (pins RP(A..D) and pins
XP(A..D)) of the PEF2256.

Signed-off-by: Herve Codina <herve.codina@bootlin.com>
So it is a bridge chip? Please use that terminology since Linux
DRM often talks about bridges.
quoted hunk ↗ jump to hunk
+++ b/drivers/pinctrl/pinctrl-pef2256-regs.h
(...)
+#include "linux/bitfield.h"
Really? I don't think there is such a file there.

Do you mean <linux/bitfield.h> and does this even compile?
quoted hunk ↗ jump to hunk
diff --git a/drivers/pinctrl/pinctrl-pef2256.c b/drivers/pinctrl/pinctrl-pef2256.c
(...)
+struct pef2256_pinctrl {
+       struct device *dev;
+       struct regmap *regmap;
+       enum pef2256_version version;
+       struct {
+               struct pinctrl_desc pctrl_desc;
+               const struct pef2256_function_desc *functions;
+               unsigned int nfunctions;
+       } pinctrl;
Uh anonymous struct... can't you just define the struct separately
with a name? Or fold it into struct pef2256_pinctrl without the
additional struct? Thanks.

Otherwise it looks neat!

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help