Re: [RFC PATCH v2 0/7] Add audio support in v4l2 framework
From: Hans Verkuil <hidden>
Date: 2023-08-02 07:33:12
Also in:
alsa-devel, linux-media, lkml
Hi all, On 25/07/2023 08:12, Shengjiu Wang wrote:
Audio signal processing has the requirement for memory to memory similar as Video. This patch is to add this support in v4l2 framework, defined new buffer type V4L2_BUF_TYPE_AUDIO_CAPTURE and V4L2_BUF_TYPE_AUDIO_OUTPUT, defined new format v4l2_audio_format for audio case usage. The created audio device is named "/dev/audioX". And add memory to memory support for two kinds of i.MX ASRC module
Before I spend time on this: are the audio maintainers OK with doing this in V4L2? I do want to have a clear statement on this as it is not something I can decide. Regards, Hans
changes in v2:
- decouple the implementation in v4l2 and ALSA
- implement the memory to memory driver as a platfrom driver
and move it to driver/media
- move fsl_asrc_common.h to include/sound folder
Shengjiu Wang (7):
ASoC: fsl_asrc: define functions for memory to memory usage
ASoC: fsl_easrc: define functions for memory to memory usage
ASoC: fsl_asrc: move fsl_asrc_common.h to include/sound
media: v4l2: Add audio capture and output support
media: imx: fsl_asrc: Add memory to memory driver
ASoC: fsl_asrc: register m2m platform device
ASoC: fsl_easrc: register m2m platform device
.../media/common/videobuf2/videobuf2-v4l2.c | 4 +
drivers/media/platform/nxp/Kconfig | 12 +
drivers/media/platform/nxp/Makefile | 1 +
drivers/media/platform/nxp/fsl_asrc_m2m.c | 962 ++++++++++++++++++
drivers/media/v4l2-core/v4l2-dev.c | 17 +
drivers/media/v4l2-core/v4l2-ioctl.c | 52 +
include/media/v4l2-dev.h | 2 +
include/media/v4l2-ioctl.h | 34 +
.../fsl => include/sound}/fsl_asrc_common.h | 48 +
include/uapi/linux/videodev2.h | 19 +
sound/soc/fsl/fsl_asrc.c | 150 +++
sound/soc/fsl/fsl_asrc.h | 4 +-
sound/soc/fsl/fsl_asrc_dma.c | 2 +-
sound/soc/fsl/fsl_easrc.c | 227 +++++
sound/soc/fsl/fsl_easrc.h | 8 +-
15 files changed, 1539 insertions(+), 3 deletions(-)
create mode 100644 drivers/media/platform/nxp/fsl_asrc_m2m.c
rename {sound/soc/fsl => include/sound}/fsl_asrc_common.h (63%)