Re: [PATCH] rtc: Kconfig: select REGMAP for RTC_DRV_DS1307
From: Christophe Leroy <hidden>
Date: 2023-07-06 05:14:52
Also in:
linux-rtc
Le 05/07/2023 à 02:30, Benjamin Gray a écrit :
quoted hunk ↗ jump to hunk
The drivers/rtc/rtc-ds1307.c driver has a direct dependency on struct regmap_config, which is guarded behind CONFIG_REGMAP. Commit 70a640c0efa7 ("regmap: REGMAP_KUNIT should not select REGMAP") exposed this by disabling the default pick unless KUNIT_ALL_TESTS is set, causing the ppc64be allnoconfig build to fail. Signed-off-by: Benjamin Gray <redacted> --- drivers/rtc/Kconfig | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index ffca9a8bb878..7455ebd189fe 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig@@ -246,6 +246,7 @@ config RTC_DRV_AS3722 config RTC_DRV_DS1307 tristate "Dallas/Maxim DS1307/37/38/39/40/41, ST M41T00, EPSON RX-8025, ISL12057" + select REGMAP
As far as I can see, REGMAP defaults to Y when REGMAP_I2C is selected. Can you explain more in details why you have to select it explicitely ? If there is something wrong with the logic, then the logic should be fixed instead of just adding a selection of REGMAP for that particular RTC_DRV_DS1307. Because others like RTC_DRV_ABB5ZES3 or RTC_DRV_ABEOZ9 might have the exact same problem.
select REGMAP_I2C select WATCHDOG_CORE if WATCHDOG help