Re: Add fchmodat2() - or add a more general syscall?
From: Christian Brauner <brauner@kernel.org>
Date: 2023-07-27 10:29:07
Also in:
linux-alpha, linux-api, linux-arch, linux-fsdevel, linux-m68k, linux-mips, linux-s390, linux-sh, lkml, sparclinux
Possibly related (same subject, not in this thread)
- 2023-07-26 · Re: Add fchmodat2() - or add a more general syscall? · Christian Brauner <brauner@kernel.org>
- 2023-07-25 · Re: Add fchmodat2() - or add a more general syscall? · Rich Felker <dalias@libc.org>
- 2023-07-25 · Re: Add fchmodat2() - or add a more general syscall? · David Howells <dhowells@redhat.com>
- 2023-07-25 · Re: Add fchmodat2() - or add a more general syscall? · Florian Weimer <hidden>
On Wed, Jul 26, 2023 at 08:57:10PM -0700, Eric Biggers wrote:
On Tue, Jul 25, 2023 at 04:58:34PM +0100, David Howells wrote:quoted
Rather than adding a fchmodat2() syscall, should we add a "set_file_attrs()" syscall that takes a mask and allows you to set a bunch of stuff all in one go? Basically, an interface to notify_change() in the kernel that would allow several stats to be set atomically. This might be of particular interest to network filesystems. Davidfchmodat2() is a simple addition that fits well with the existing syscalls. It fixes an oversight in fchmodat(). IMO we should just add fchmodat2(), and not get sidetracked by trying to add some super-generalized syscall instead. That can always be done later.
Agreed.