[PATCH v2 07/18] vfio-mdev: Remove flag FBINFO_DEFAULT from fbdev sample driver
flat view
STALE1188d
SUPERSEDED: 1 (0M)
From: Thomas Zimmermann <tzimmermann@suse.de>
Date: 2023-07-13 13:04:32
Also in:
amd-gfx, dri-devel, kvm, linux-arm-kernel, linux-fbdev, linux-hyperv, linux-input, linux-media, linux-omap, linux-sh, linux-staging, lkml
Subsystem:
the rest, vfio mediated device drivers · Maintainers:
Linus Torvalds, Kirti Wankhede
Revision v2 of 4 in this series; 1 review trailer.
Revisions (4)
- v1 [diff vs current]
- v2 current
- v3 [diff vs current]
- v4 [diff vs current]
The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix commit message (Miguel) Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Sam Ravnborg <redacted> Cc: Kirti Wankhede <kwankhede@nvidia.com> --- samples/vfio-mdev/mdpy-fb.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/samples/vfio-mdev/mdpy-fb.c b/samples/vfio-mdev/mdpy-fb.c
index 3c8001b9e407..cda477b28685 100644
--- a/samples/vfio-mdev/mdpy-fb.c
+++ b/samples/vfio-mdev/mdpy-fb.c@@ -162,7 +162,6 @@ static int mdpy_fb_probe(struct pci_dev *pdev, } info->fbops = &mdpy_fb_ops; - info->flags = FBINFO_DEFAULT; info->pseudo_palette = par->palette; ret = register_framebuffer(info);
--
2.41.0