Re: [kvm-unit-tests PATCH 2/2] Link with "-z noexecstack" to avoid warning from newer versions of ld
From: Sean Christopherson <seanjc@google.com>
Date: 2023-06-23 14:25:49
Also in:
kvm, kvmarm, linux-s390
On Fri, Jun 23, 2023, Thomas Huth wrote:
quoted hunk ↗ jump to hunk
Newer versions of ld (from binutils 2.40) complain on s390x and x86: ld: warning: s390x/cpu.o: missing .note.GNU-stack section implies executable stack ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker We can silence these warnings by using "-z noexecstack" for linking (which should not have any real influence on the kvm-unit-tests since the information from the ELF header is not used here anyway, so it's just cosmetics). Signed-off-by: Thomas Huth <redacted> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/Makefile b/Makefile index 0e5d85a1..20f7137c 100644 --- a/Makefile +++ b/Makefile@@ -96,7 +96,7 @@ CFLAGS += -Woverride-init -Wmissing-prototypes -Wstrict-prototypes autodepend-flags = -MMD -MF $(dir $*).$(notdir $*).d -LDFLAGS += -nostdlib +LDFLAGS += -nostdlib -z noexecstack
Drat, the pull request[1] I sent to Paolo yesterday only fixes x86[2]. Paolo, want me to redo the pull request to drop the x86-specific patch? [1] https://lore.kernel.org/all/20230622211440.2595272-1-seanjc@google.com (local) [2] https://lore.kernel.org/all/20230406220839.835163-1-seanjc@google.com (local)