Re: [PATCH 15/17] perf tests task_analyzer: fix bad substitution ${$1}
From: Aditya Gupta <hidden>
Date: 2023-06-21 10:06:17
Also in:
linux-perf-users
Hello Namhyung, On 21/06/23 06:18, Namhyung Kim wrote:
quoted hunk ↗ jump to hunk
Hello, On Tue, Jun 13, 2023 at 1:06 PM Arnaldo Carvalho de Melo [off-list ref] wrote:quoted
Em Tue, Jun 13, 2023 at 10:11:43PM +0530, Athira Rajeev escreveu:quoted
This issue due to ${$1} caused all function calls to give error in `find_str_or_fail` line, and so no test runs completely. But 'perf test "perf script task-analyzer tests"' wrongly reports that tests passed with the status OK, which is wrong considering the tests didn't even run completely Fixes: e8478b84d6ba ("perf test: add new task-analyzer tests") Signed-off-by: Athira Rajeev <redacted> Signed-off-by: Kajol Jain <redacted> Signed-off-by: Aditya Gupta <redacted> ---I'm seeing a different error even after this fix. Can you please take a look? Thanks, Namhyung $ sudo ./perf test -v task 114: perf script task-analyzer tests :--- start ---test child forked, pid 1771042 Please specify a valid report script(see 'perf script -l' for listing) FAIL: "invocation of perf command failed" Error message: "" FAIL: "test_basic" Error message: "Failed to find required string:'Comm'." Please specify a valid report script(see 'perf script -l' for listing) FAIL: "invocation of perf command failed" Error message: "" FAIL: "test_ns_rename" Error message: "Failed to find required string:'Comm'." ... test child finished with -1 ---- end ---- perf script task-analyzer tests: FAILED!
Can you please check if your environment has libtraceevent devel libraries (or did you compile with `make NO_LIBTRACEEVENT=1`) ? When libtraceevent support is not there, perf record fails and so perf.data doesn't contain the strings it's searching for and hence those errors The error you mentioned has been mentioned and fixed in patch 17/17 of this series. Thanks - Aditya