On Wed 2023-06-21 16:48:19, Douglas Anderson wrote:
The powerpc architecture was the only one that defined
arch_trigger_cpumask_backtrace() in asm/nmi.h instead of
asm/irq.h. Move it to be consistent.
This fixes compile time errors introduced by commit 7ca8fe94aa92
("watchdog/hardlockup: define HARDLOCKUP_DETECTOR_ARCH"). That commit
Will this commit end up in the mainline wihtout rebasing?
We could use only final commit hashes in the commit messages.
caused <asm/nmi.h> to stop being included if the hardlockup detector
wasn't enabled. The specific errors were:
error: implicit declaration of function ‘nmi_cpu_backtrace’
error: implicit declaration of function ‘nmi_trigger_cpumask_backtrace’
Fixes: 7ca8fe94aa92 ("watchdog/hardlockup: define HARDLOCKUP_DETECTOR_ARCH")
Reported-by: Michael Ellerman <mpe@ellerman.id.au>
Closes: https://lore.kernel.org/r/871qi5otdh.fsf@mail.lhotse (local)
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Looks like a reasonable solution:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Thanks a lot for fixing the regression.
Best Regards,
Petr