Re: [PATCH v2 4/6] watchdog/hardlockup: Make HAVE_NMI_WATCHDOG sparc64-specific

From
Petr Mladek <pmladek@suse.com>
Date
2023-06-19 09:55:15
Also in
linux-perf-users, lkml, sparclinux
Reply to
Doug Anderson, 2023-06-16
On Fri 2023-06-16 09:48:06, Doug Anderson wrote:
Hi,

On Fri, Jun 16, 2023 at 8:07 AM Petr Mladek [off-list ref] wrote:
quoted
There are several hardlockup detector implementations and several Kconfig
values which allow selection and build of the preferred one.
[...]
quoted
Note that HARDLOCKUP_DETECTOR_PREFER_BUDDY, HARDLOCKUP_DETECTOR_PERF,
and HARDLOCKUP_DETECTOR_BUDDY may conflict only with
HAVE_HARDLOCKUP_DETECTOR_ARCH. They depend on HARDLOCKUP_DETECTOR
and it is not longer enabled when HAVE_NMI_WATCHDOG is set.

Signed-off-by: Petr Mladek <pmladek@suse.com>

watchdog/sparc64: Rename HAVE_NMI_WATCHDOG to HAVE_HARDLOCKUP_WATCHDOG_SPARC64
[...]
quoted
Also the variable is set only on sparc64. Move the definition
from arch/Kconfig to arch/sparc/Kconfig.debug.

Signed-off-by: Petr Mladek <pmladek@suse.com>
I think you goofed up when squashing the patches. You've now got a
second patch subject after your first Signed-off-by and then a second
Signed-off-by... I assume everything after the first Signed-off-by
should be dropped?
Ah, you are right. It seems that Andrew has fixed this when taking
the patch.

Thank you both,
Petr
Thread (18 messages) 18 messages, 4 authors, last reply 2023-07-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help