Re: [PATCH mm-unstable v2 01/10] mm/kvm: add mmu_notifier_ops->test_clear_young()
From: Paolo Bonzini <pbonzini@redhat.com>
Date: 2023-06-09 09:06:21
Also in:
kvm, kvmarm, linux-arm-kernel, linux-doc, linux-mm, linux-trace-kernel, lkml
Possibly related (same subject, not in this thread)
- 2023-06-20 · Re: [PATCH mm-unstable v2 01/10] mm/kvm: add mmu_notifier_ops->test_clear_young() · "Nicholas Piggin" <npiggin@gmail.com>
- 2023-06-15 · Re: [PATCH mm-unstable v2 01/10] mm/kvm: add mmu_notifier_ops->test_clear_young() · Sean Christopherson <seanjc@google.com>
- 2023-06-09 · Re: [PATCH mm-unstable v2 01/10] mm/kvm: add mmu_notifier_ops->test_clear_young() · Yu Zhao <hidden>
- 2023-06-06 · Re: [PATCH mm-unstable v2 01/10] mm/kvm: add mmu_notifier_ops->test_clear_young() · Tzung-Bi Shih <tzungbi@kernel.org>
- 2023-05-26 · [PATCH mm-unstable v2 01/10] mm/kvm: add mmu_notifier_ops->test_clear_young() · Yu Zhao <hidden>
On 5/31/23 21:17, Jason Gunthorpe wrote:
quoted
+ int (*test_clear_young)(struct mmu_notifier *mn, struct mm_struct *mm, + unsigned long start, unsigned long end, + bool clear, unsigned long *bitmap); +Why leave clear_young behind? Just make a NULL bitmap mean clear_young?
It goes away in patch 2, together with:
@@ -437,7 +412,7 @@ static inline int mmu_notifier_clear_young(struct mm_struct *mm, unsigned long end) { if (mm_has_notifiers(mm)) - return __mmu_notifier_clear_young(mm, start, end); + return __mmu_notifier_test_clear_young(mm, start, end, true, NULL); return 0; }
@@ -445,7 +420,7 @@ static inline int mmu_notifier_test_young(struct mm_struct *mm, unsigned long address) { if (mm_has_notifiers(mm)) - return __mmu_notifier_test_young(mm, address); + return __mmu_notifier_test_clear_young(mm, address, address + 1, false, NULL); return 0; }
Paolo