Thread (33 messages) 33 messages, 5 authors, 2023-05-16

Re: [PATCH v14 07/15] phy: fsl: Add Lynx 10G SerDes driver

From: Vinod Koul <vkoul@kernel.org>
Date: 2023-05-16 13:36:54
Also in: linux-arm-kernel, linux-devicetree, linux-doc, linux-phy

On 08-05-23, 11:28, Sean Anderson wrote:
On 5/8/23 05:22, Vinod Koul wrote:
quoted
On 13-04-23, 12:05, Sean Anderson wrote:
quoted
quoted
+static const struct lynx_cfg ls1088a_cfg = {
+	.lanes = 4,
+	.endian = REGMAP_ENDIAN_LITTLE,
+	.mode_conflict = lynx_ls_mode_conflict,
+	.mode_apply = lynx_ls_mode_apply,
+	.mode_init = lynx_ls_mode_init,
So you have cfg with mode_xxx pointing to same functions for both of the
versions you support... so question is why do this and not call the
functions directly?
The intention is to make it easy to add support for T-series processors,
which have a different PCCR layout.
And when is that going to come. I would prefer this to be added when we
have users being added

-- 
~Vinod
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help