Re: [PATCH v2 21/34] arm64: Convert various functions to use ptdescs
From: kernel test robot <hidden>
Date: 2023-05-02 15:20:39
Also in:
kvm, linux-arch, linux-arm-kernel, linux-m68k, linux-mips, linux-mm, linux-riscv, linux-s390, linux-sh, linux-um, llvm, loongarch, oe-kbuild-all, sparclinux, xen-devel
Hi Vishal, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master next-20230428] [cannot apply to s390/features powerpc/next powerpc/fixes geert-m68k/for-next geert-m68k/for-linus v6.3] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Vishal-Moola-Oracle/mm-Add-PAGE_TYPE_OP-folio-functions/20230502-033042 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230501192829.17086-22-vishal.moola%40gmail.com patch subject: [PATCH v2 21/34] arm64: Convert various functions to use ptdescs config: arm64-randconfig-r023-20230430 (https://download.01.org/0day-ci/archive/20230502/202305021038.c9jfVDsv-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project b1465cd49efcbc114a75220b153f5a055ce7911f) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/8e9481b63b5773d7c914836dcd7fbec2449902bc git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Vishal-Moola-Oracle/mm-Add-PAGE_TYPE_OP-folio-functions/20230502-033042 git checkout 8e9481b63b5773d7c914836dcd7fbec2449902bc # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot [off-list ref] | Link: https://lore.kernel.org/oe-kbuild-all/202305021038.c9jfVDsv-lkp@intel.com/ (local) All errors (new ones prefixed by >>):
quoted
arch/arm64/mm/mmu.c:440:10: error: invalid argument type 'void' to unary expression
BUG_ON(!ptdesc_pte_dtor(ptdesc));
^~~~~~~~~~~~~~~~~~~~~~~~
include/asm-generic/bug.h:71:45: note: expanded from macro 'BUG_ON'
#define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (0)
^~~~~~~~~
include/linux/compiler.h:78:42: note: expanded from macro 'unlikely'
# define unlikely(x) __builtin_expect(!!(x), 0)
^
arch/arm64/mm/mmu.c:442:10: error: invalid argument type 'void' to unary expression
BUG_ON(!ptdesc_pte_dtor(ptdesc));
^~~~~~~~~~~~~~~~~~~~~~~~
include/asm-generic/bug.h:71:45: note: expanded from macro 'BUG_ON'
#define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (0)
^~~~~~~~~
include/linux/compiler.h:78:42: note: expanded from macro 'unlikely'
# define unlikely(x) __builtin_expect(!!(x), 0)
^
2 errors generated.
vim +/void +440 arch/arm64/mm/mmu.c
425
426 static phys_addr_t pgd_pgtable_alloc(int shift)
427 {
428 phys_addr_t pa = __pgd_pgtable_alloc(shift);
429 struct ptdesc *ptdesc = page_ptdesc(phys_to_page(pa));
430
431 /*
432 * Call proper page table ctor in case later we need to
433 * call core mm functions like apply_to_page_range() on
434 * this pre-allocated page table.
435 *
436 * We don't select ARCH_ENABLE_SPLIT_PMD_PTLOCK if pmd is
437 * folded, and if so ptdesc_pte_dtor() becomes nop.
438 */
439 if (shift == PAGE_SHIFT)
> 440 BUG_ON(!ptdesc_pte_dtor(ptdesc));
441 else if (shift == PMD_SHIFT)
442 BUG_ON(!ptdesc_pte_dtor(ptdesc));
443
444 return pa;
445 }
446
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests