Re: [PATCH v2 RESEND] soc/fsl/qe: fix usb.c build errors
From: Nicolas Schier <hidden>
Date: 2023-05-31 07:31:42
Also in:
linux-arm-kernel, lkml
On Sun, May 21, 2023 at 03:52:16PM -0700 Randy Dunlap wrote:
Fix build errors in soc/fsl/qe/usb.c when QUICC_ENGINE is not set.
This happens when PPC_EP88XC is set, which selects CPM1 & CPM.
When CPM is set, USB_FSL_QE can be set without QUICC_ENGINE
being set. When USB_FSL_QE is set, QE_USB deafults to y, which
causes build errors when QUICC_ENGINE is not set. Making
QE_USB depend on QUICC_ENGINE prevents QE_USB from defaulting to y.
Fixes these build errors:
drivers/soc/fsl/qe/usb.o: in function `qe_usb_clock_set':
usb.c:(.text+0x1e): undefined reference to `qe_immr'
powerpc-linux-ld: usb.c:(.text+0x2a): undefined reference to `qe_immr'
powerpc-linux-ld: usb.c:(.text+0xbc): undefined reference to `qe_setbrg'
powerpc-linux-ld: usb.c:(.text+0xca): undefined reference to `cmxgcr_lock'
powerpc-linux-ld: usb.c:(.text+0xce): undefined reference to `cmxgcr_lock'
Fixes: 5e41486c408e ("powerpc/QE: add support for QE USB clocks routing")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: kernel test robot <redacted>
Link: https://lore.kernel.org/all/202301101500.pillNv6R-lkp@intel.com/ (local)
Suggested-by: Michael Ellerman <mpe@ellerman.id.au>
Cc: Christophe Leroy <redacted>
Cc: Leo Li <redacted>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Nicolas Schier <redacted>
Cc: Qiang Zhao <qiang.zhao@nxp.com>
Cc: linuxppc-dev <redacted>
Cc: linux-arm-kernel@lists.infradead.org
Cc: Kumar Gala <redacted>
---I can reproduce the build error and confirm the build dependency fix (but I have no hardware for testing). Acked-by: Nicolas Schier <redacted>
quoted hunk ↗ jump to hunk
v2: drop Anton Vorontsov [off-list ref]; rebase/resend drivers/soc/fsl/qe/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/drivers/soc/fsl/qe/Kconfig b/drivers/soc/fsl/qe/Kconfig--- a/drivers/soc/fsl/qe/Kconfig +++ b/drivers/soc/fsl/qe/Kconfig@@ -62,6 +62,7 @@ config QE_TDM config QE_USB bool + depends on QUICC_ENGINE default y if USB_FSL_QE help QE USB Controller support
--
epost|xmpp: nicolas@fjasle.eu irc://oftc.net/nsc
↳ gpg: 18ed 52db e34f 860e e9fb c82b 7d97 0932 55a0 ce7f
-- frykten for herren er opphav til kunnskap --